Conversation
Member
|
I would actually prefer to have a separate exception class that extends from LockedException and contains the additional details like lock owner, time |
juliusknorr
requested review from
ChristophWurst,
blizzz,
juliusknorr and
rullzer
Member
Author
|
@juliushaertl this would limit the app to 18, which is not a big deal. Please have a look to the new TemporaryLockedException |
This was referenced Nov 27, 2019
juliusknorr
reviewed
Dec 5, 2019
ChristophWurst
requested changes
Dec 5, 2019
ArtificialOwl
force-pushed
the
enhancement/noid/add-timeout
branch
2 times, most recently
from
4a3bc37 to
a9102dc
Compare
ChristophWurst
requested changes
Dec 5, 2019
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Should still be type-hinted, even if nullable :)
Member
Author
|
ok, learnt something today. should be ok now |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
enhancement/noid/add-timeout
branch
from
f7eda02 to
9bdc582
Compare
ChristophWurst
approved these changes
Dec 13, 2019
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
juliusknorr
approved these changes
Dec 19, 2019
ChristophWurst
added
the
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would help any app trying to save into a locked file to known the estimated timeout when catching the LockedException.
As an example, it will make the Text App not trying to sync every 5s if the lock is initiated by the FilesLock app.