Conversation
Contributor
Author
|
Scary. The build passed ;) |
icewind1991
approved these changes
Nov 11, 2019
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de> Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5441a18 to
4a972e7
Compare
Member
|
Rebased |
rullzer
approved these changes
Nov 12, 2019
gary-kim
approved these changes
Nov 12, 2019
Member
Seems to have been getting a lot more reliable recently. Well, I say that, we went from passing being rare to being uncommon. Is someone doing work on getting the build agents more reliable? |
1 task
|
Please also backport to 16.0.7. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #17447
Bump icewind/searchdav to fix a infinite loop discovered by @NaofumiHonda caused by xml parsing issues.
I think we should backport it to 17.0.2 if possible.