move select2 styles to core so it's universal, not only for tags

[jancborchardt]

Before & after: Much more breathing space, less complexity and lines, nice Nextcloud style, and proper connection to the input field:

Please review @nextcloud/designers @ErikPel @nextcloud/javascript you can test it with:

• System tags in the files sidebar
• Enabling apps only for specific users in apps mgmt
• New person selector in Spreed app: [WIP] Add person selector spreed#55

The one problem which still occurs (also with old version) is that the dropdown is about 3 pixels too wide on the right. Any idea @nextcloud/javascript? (NOT A BLOCKER)

[mention-bot]

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @vincchan and @Henni to be potential reviewers.

[LukasReschke]

Works locally. Looks nice! 🚀

LGTM

[skjnldsv]

@jancborchardt it's because the dropdown uses the width of .select2-choices
And it has margin which sums up to 333px instead of what you wanted.

[skjnldsv]

here this is you issue @jancborchardt

[jancborchardt]

Fixed while keeping the margin on the container, thank you! :)

[skjnldsv]

Ps: there's a lot of !important overriding. Is this really necessary? Shouldn't we load the jquery theme before instead?

[jancborchardt]

Ps: there's a lot of !important overriding. Is this really necessary? Shouldn't we load the jquery theme before instead?

I agree. @MorrisJobke @LukasReschke how can we change the order here? The inputs.css should be one of the last loaded.

[MorrisJobke]

I agree. @MorrisJobke @LukasReschke how can we change the order here? The inputs.css should be one of the last loaded.

Crash course for @jancborchardt how to do this:

1. use the search tool of your choice to search for where the CSS is imported
2. change the order there
3. don't always out source this to other people - even if you think this would be nice because they know where - we are no weird dudes who have all the files and lines in our head - we also always use the search tools

[MorrisJobke]

don't always out source this to other people - even if you think this would be nice because they know where - we are no weird dudes who have all the files and lines in our head - we also always use the search tools

server/lib/private/legacy/template.php

Line 120 in b4f36d4

OC_Util::addStyle("inputs",null,true);

[skjnldsv]

The order is reversed when implementing. So in the file @MorrisJobke pointed (thanks 😉 ) you need to pu inputs BEFORE jquery! 😁

[jancborchardt]

@MorrisJobke I searched for it, but since it was called legacy I assumed it’s not used anymore. There was another file which looked like it’s done there and it seemed like it just loaded all the files from the CSS directory. So thanks for helping.

[jancborchardt]

Experimented with removing all the !importants and with changing the order – doesn’t work. If anyone can make it work I’m happy for enhancements, but I’d say let’s get it in.

[skjnldsv]

This is strange! 😕
Okay, this is because select2 is coming after. Its from the app systemtags.

[skjnldsv]

@jancborchardt maybe we should add this into the systemtags apps? Since this is only used here?

[MorrisJobke]

The order is reversed when implementing. So in the file @MorrisJobke pointed (thanks 😉 ) you need to pu inputs BEFORE jquery! 😁

Correct - this is a bit weird, but you figured it out 😉

[MorrisJobke]

👍

[jancborchardt]

maybe we should add this into the systemtags apps? Since this is only used here?

No – as said above it’s also used elsewhere like app mgmt and the spreed app. :) That’s the point of this PR, to make the select2 style adjustments more general.

[skjnldsv]

Okay! :)
So maybe we should add the select2 style injection in core and not systemtags then :p

[jancborchardt]

@skjnldsv that’s what I did here, moved most of the select2 styles from systemtag.css to core/css/inputs.css ;)

[skjnldsv]

Yes, but I mean the addStyle function from

server/lib/private/legacy/template.php

Line 120 in b4f36d4

OC_Util::addStyle("inputs",null,true);

Would be better than loading it from here https://github.com/nextcloud/server/blob/master/apps/systemtags/appinfo/app.php#L35

[jancborchardt]

@skjnldsv good point! Do you want to do the change in a pull request? :)

[skjnldsv]

I'm busy with the scss! 😁
Do it !