Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks better, thanks! :) There’s still that pesky issue of: Container on update screen is too wide #17556
| <input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" /> | ||
| <div id="submit-wrapper"> | ||
| <input type="submit" id="submit" class="login primary" title="" value="<?php p($l->t('Grant access')); ?>" /> | ||
| <div class="submit-icon icon-confirm-white"></div> |
There was a problem hiding this comment.
Hmm. https://github.com/nextcloud/server/search?q=submit-icon&unscoped_q=submit-icon .submit-icon is used by grant.js but this script is only loaded for loginflow v1.
|
Do you want this fancy loading animation back @jancborchardt ?
|
Is that shown after tapping the button as feedback? If so then yes, feedback is always good. :) |
Refactor grant.js to Vanilla JS Remove id="submit" because of side effects: https://stackoverflow.com/questions/22982741/form-submit-jquery-does-not-work Fix arrow for login flow v1 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
|
OK. It was broken for login flow v1 either. Fixed both and rewrote it without jquery. Now we need some js power ;) |
skjnldsv
added
4. to release
|
|
|
So we can merge this? Or should we transpile grant.js? |
I think |
4 participants
Master
This PR
