Fix getContent so body content stream can be accessed on POST method#17425
Closed
xklonx wants to merge 5 commits intonextcloud:masterfrom
Closed
Fix getContent so body content stream can be accessed on POST method#17425xklonx wants to merge 5 commits intonextcloud:masterfrom
xklonx wants to merge 5 commits intonextcloud:masterfrom
Conversation
ChristophWurst
requested changes
Oct 21, 2019
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
L424 still only mentions put in the exception message
ChristophWurst
approved these changes
Oct 24, 2019
Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
exception message Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
Contributor
Author
|
Method __get get called before controller execution to get parameters for controller method. Therefore, I think that in switch cases params and parameters, only an parsed array is needed. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsv
requested review from
a team,
ArtificialOwl,
come-nc and
nickvergessen
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
Member
|
@xklonx can you rebase and squash all commits into one please? |
Merged
Merged
Merged
Merged
Merged
Merged
Member
|
Closing for inactivity. Code needs to be adjusted to current code base, but it should be pretty easy. If someone is interesting in it, open a new PR with the modifications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to get file from body of POST request, but there is no way to get Request->inputStream so i think this fix is correct.