Skip to content

Allow to have mutliple buttons on the filepicker#17260

Merged
rullzer merged 1 commit intomasterfrom
feature/noid/filepicker-allow-multiple-buttons
Dec 10, 2019
Merged

Allow to have mutliple buttons on the filepicker#17260
rullzer merged 1 commit intomasterfrom
feature/noid/filepicker-allow-multiple-buttons

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 25, 2019

Required for Talk for Nextcloud 18:
nextcloud/spreed#2193

@nickvergessen nickvergessen added this to the Nextcloud 18 milestone Sep 25, 2019
@nickvergessen nickvergessen mentioned this pull request Sep 25, 2019
Closed
12 tasks
skjnldsv
skjnldsv approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok

@szaimen
Copy link
Contributor

szaimen commented Oct 18, 2019

Any update here?

juliusknorr
juliusknorr approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@juliusknorr
Copy link
Member

juliusknorr commented Oct 23, 2019

@nickvergessen Mind to rebase?

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2019

@nickvergessen any update here?
Would be really nice to get nextcloud/spreed#2193 ready for Nextcloud 18 :)

@nickvergessen nickvergessen force-pushed the feature/noid/filepicker-allow-multiple-buttons branch from 0774d3b to 1396f3a Compare December 3, 2019 18:45
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 3, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 7, 2019

please rebase

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 7, 2019
@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 7, 2019

Rebasing every 4 days? Just rebase it and merge it 😬

@nickvergessen nickvergessen force-pushed the feature/noid/filepicker-allow-multiple-buttons branch from 1396f3a to a2cd1e7 Compare December 9, 2019 11:48
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Dec 9, 2019
@nickvergessen @rullzer
Allow to have mutliple buttons on the filepicker
aa790a3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@rullzer rullzer force-pushed the feature/noid/filepicker-allow-multiple-buttons branch from a2cd1e7 to aa790a3 Compare December 9, 2019 14:55
@rullzer
Copy link
Member

rullzer commented Dec 9, 2019

/compile amend /

@rullzer rullzer merged commit b78a141 into master Dec 10, 2019
@rullzer rullzer deleted the feature/noid/filepicker-allow-multiple-buttons branch December 10, 2019 08:05
@rullzer rullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: filepicker high

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @szaimen @juliusknorr @skjnldsv @rullzer