replaces upsert with traditional catch

[blizzz]

cf. #16461 (comment)

If that's all that is necessary, we can forward port it to master actually. Also since Stretch will be around for a while. Then we undo the >=9.5 check.

[blizzz]

@oole would be nice if you could check this, too

[kesselb]

server/lib/private/DB/Adapter.php

Lines 133 to 144 in f889bea

	public function insertIgnoreConflict(string $table,array $values) : int {
	try {
	$builder = $this->conn->getQueryBuilder();
	$builder->insert($table);
	foreach($values as $key => $value) {
	$builder->setValue($key, $builder->createNamedParameter($value));
	}
	return $builder->execute();
	} catch(UniqueConstraintViolationException $e) {
	return 0;
	}
	}

Looks similar. Why don't you remove the child implementation? #12729 A lot of pgsql users will see these warnings in their logs again.

Also since Stretch will be around for a while

https://packages.debian.org/search?suite=stretch&keywords=postgresql 🤔

[nickvergessen]

We can then also revert the required postgres version to 9?

[blizzz]

We can then also revert the required postgres version to 9?

that's against 16 now, there we didn't increase it yet.

[blizzz]

Looks similar. Why don't you remove the child implementation?

Yes, why, I actually looked at it. You're right, we can get rid of it.

[blizzz]

Anyhow, on UCS with 9.4 it works at least in regular operation, did not come across an error case here. Let me get this done in master properly and we backport it. Messy affair, could have been solved more elegantly, sorry :-/