Conversation
The old notifications were added as ".row" elements to the "#notification-container" element; the new notifications based on toastify are added as ".toastify .on .toast..." elements to the "#content" element. Besides that, they also include a span element with an X to close the notification, so now only the first child text node should be compared to the expected message. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
skjnldsv
approved these changes
Jun 12, 2019
juliusknorr
approved these changes
Jun 13, 2019
juliusknorr
added
4. to release
skjnldsv
deleted the
adjust-acceptance-tests-to-notifications-based-on-toastify
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #15124
Note that notifications are not checked in any of the acceptance tests of the server, although they are in Talk. The failure in the acceptance tests in Drone is unrelated to this change and it is fixed in a different pull request.