Decouple remote wipe notifcation channels with events#15775
Merged
georgehrke merged 1 commit intomasterfrom Jul 2, 2019
Merged
Decouple remote wipe notifcation channels with events#15775georgehrke merged 1 commit intomasterfrom
georgehrke merged 1 commit intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
ChristophWurst
force-pushed
the
refactor/decouple-remote-wipe-notifications
branch
2 times, most recently
from
f0fb875 to
91fb2ae
Compare
lib/private/Authentication/Listeners/RemoteWipeActivityListener.php
Outdated
Show resolved
Hide resolved
lib/private/Authentication/Listeners/RemoteWipeActivityListener.php
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private function sendNotification(string $event, IToken $token): void { | ||
| $notification = $this->notificationManager->createNotification(); |
Member
There was a problem hiding this comment.
Do we want to send those as normal notifications,
or more like the silent notification when a notification is deleted on another device?
Similar to nextcloud/notifications#318
That would allow us, to send it only to the affected device.
In that case I would simply trigger an event and make the notifications app listen to it and then do it's magic there.
Member
Author
There was a problem hiding this comment.
Fine by me. Can we do this in a follow-up PR? The little refactoring exercise here is needed to also add e-mail notifications 😉
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
refactor/decouple-remote-wipe-notifications
branch
from
91fb2ae to
aa6622c
Compare
rullzer
approved these changes
Jun 27, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Awesome!
Code looks good.
I tested it and it works as advertised! 🚀
rullzer
added
3. to review
ChristophWurst
added
4. to release
ChristophWurst
added
3. to review
georgehrke
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #15646.
Todo