Adjust acceptance tests to changes of file names in file picker#14947
Merged
MorrisJobke merged 1 commit intomasterfrom Apr 3, 2019
Merged
Conversation
File names are no longer shown directly in the ".filename" element, but split in two "span" elements inside a ".filename-parts" element, so now the texts in those span elements need to be concatenated to get the file name. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
approved these changes
Apr 3, 2019
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17477: failureTESTS=ui-regression
|
MorrisJobke
deleted the
adjust-acceptance-tests-to-changes-of-file-names-in-file-picker
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #14912
The acceptance tests in server did not fail because the file picker is not exercised in them, although it is in Talk tests.