Properly inject EventDispatched in BackgroundRepair

[rullzer]

Else it will just be null when called

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[ChristophWurst]

Sure

[MorrisJobke]

If this is only executed in tests, why did it work then in the actual code?

[MorrisJobke]

It is then actually needed in line 94. 🤔

[nickvergessen]

It's only used in

server/lib/private/legacy/app.php

Lines 983 to 985 in 769cb62

	$queue->add('OC\Migration\BackgroundRepair', [
	'app' => $appId,
	'step' => $step]);

so I guess it just always ran without events

[nickvergessen]

Because

server/lib/private/Repair.php

Lines 195 to 198 in e819e97

	if (!is_null($this->dispatcher)) {
	$this->dispatcher->dispatch("$scope::$method",
	new GenericEvent("$scope::$method", $arguments));
	}

checks existence before using it

[MorrisJobke]

But shouldn't then this fail?

server/lib/private/Repair.php

Line 80 in e819e97

public function __construct(array $repairSteps, EventDispatcherInterface $dispatcher) {

because there is only a type hint and not an explicit = null. Or is this only causing issues in strict mode?

[MorrisJobke]

Is there already a PR, because I can't find any.

[rullzer]

This is it. We now properly inject it.

[MorrisJobke]

But where? 🤔

[kesselb]

[MorrisJobke]

I was referencing the initialization of a new BackgroundRepair instance. But you are right - they are added to the queue and the queue then uses the DI container. Sorry for the noise.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17256: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

• tests/acceptance/features/app-files-sharing-link.feature:128

Show full log

  Scenario: access a shared link protected by password with an invalid password                # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:128
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
      Element is no longer attached to the DOM
      For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      System info: host: 'aae1d19bb3de', ip: '172.17.0.8', os.name: 'Linux', os.arch: 'amd64', os.version: '4.4.0-141-generic', java.version: '1.8.0_91'
      Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I authenticate with password "fedcba"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the Authenticate page for the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I see that a wrong password for the shared file message is shown                       # PublicShareContext::iSeeThatAWrongPasswordForTheSharedFileMessageIsShown()