Make appstore app:enable test more robust by repeating if it fails on the first try

[MorrisJobke]

Fixes the issue from #14640 (comment)

[MorrisJobke]

/backport to stable15

[MorrisJobke]

/backport to stable14

[kesselb]

Backport will fail because the tests are new. The test only works if app store is available and there is a release of the contacts app. Tests will fail again if you bump version to 17. I think we should disable the tests with the contact app for now.

[MorrisJobke]

@kesselb I changed the app to a shipped one.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16990: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

• tests/acceptance/features/apps.feature:75
• tests/acceptance/features/apps.feature:83

Show full log

  Scenario: View app details for app store apps   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:75
    Given I act as Jane                           # ActorContext::iActAs()
    And I am logged in as the admin               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                # AppNavigationContext::iOpenTheSection()
    When I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
      Row for app Antivirus for files in Apps Management could not be found after 100 seconds (NoSuchElementException)
    Then I see that the app details are shown     # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

  Scenario: Install an app from the app store                     # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:83
    Given I act as Jane                                           # ActorContext::iActAs()
    And I am logged in as the admin                               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    And I click on the "Antivirus for files" app                  # AppsManagementContext::iClickOnTheApp()
    And I see that the app details are shown                      # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
    Then I download and enable the "Antivirus for files" app      # AppsManagementContext::iDownloadAndEnableTheApp()
    And I see that the "Antivirus for files" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

[MorrisJobke]

TESTS=acceptance, TESTS-ACCEPTANCE=apps

• tests/acceptance/features/apps.feature:75
• tests/acceptance/features/apps.feature:83

Commented in 70f90b8 in #14681

[backportbot-nextcloud]

The backport to stable15 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable14 failed. Please do this backport manually.

[MorrisJobke]

No need to back port - the command was added to 16.