Do not allow invalid users to be created#14652
Merged
nickvergessen merged 1 commit intomasterfrom Mar 14, 2019
Merged
Conversation
kesselb
requested changes
Mar 13, 2019
kesselb
approved these changes
Mar 13, 2019
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 16946: failureDB=sqlite, ENABLE_REDIS=false, PHP=7.3Show full logTESTS=integration-federation_features
Show full logTESTS=acceptance, TESTS-ACCEPTANCE=app-files
TESTS=sqlite-php7.1-samba-non-nativeShow full log |
rullzer
force-pushed
the
fix/invalid_usernames
branch
from
19142fe to
6b56980
Compare
MorrisJobke
added
4. to release
Member
|
CI fixed in #14640 Status of 16951: killedDB=sqlite, ENABLE_REDIS=false, PHP=7.3Show full logTESTS=integration-federation_features
Show full logTESTS=integration-downloadTESTS=acceptance, TESTS-ACCEPTANCE=app-files
Show full log |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
force-pushed
the
fix/invalid_usernames
branch
from
6b56980 to
969fc45
Compare
Member
|
Retriggered CI. |
| private function verifyUid(string $uid): bool { | ||
| $appdata = 'appdata_' . $this->config->getSystemValueString('instanceid'); | ||
|
|
||
| if ($uid === '.htaccess' || $uid === 'files_external' || $uid === '.ocdata' || $uid === 'owncloud.log' || $uid === 'nextcloud.log' || $uid === $appdata) { |
There was a problem hiding this comment.
Why not reject all UIDs for which there exists a file or folder in the data directory? Also, you forgot index.html, owncloud.db, owncloud.db-shm, owncloud.db-wal.
Member
There was a problem hiding this comment.
Why not reject all UIDs for which there exists a file or folder in the
datadirectory?
We then need to first check the existing user as well, right?
There was a problem hiding this comment.
I don't understand.. What do you want to check, when?
Member
There was a problem hiding this comment.
because otherwise a valid UID is not valid anymore once the user is created and thus has a user folder in there.
There was a problem hiding this comment.
What's the problem about having existing users with an invalid UID (which was valid before)?
Member
There was a problem hiding this comment.
So, what about those additional files? And Why not reject all UIDs for which there exists a file or folder in the data directory??
Member
There was a problem hiding this comment.
So, what about those additional files? And
Why not reject all UIDs for which there exists a file or folder in the data directory??
Makes sense 👍 We should additionally keep the list here to avoid future collisions for not yet created log files or something like that.
There was a problem hiding this comment.
Hey, has this been implemented already?
Member
|
Just discussed with @nickvergessen:
|
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
|
backport to stable15 in #15071 |
|
backport to stable14 in #15072 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl