Improve update channel layout to be a popup menu#14168
Merged
MorrisJobke merged 2 commits intomasterfrom Feb 14, 2019
Merged
Conversation
MorrisJobke
added
enhancement
design
MorrisJobke
requested review from
ChristophWurst,
juliusknorr,
nickvergessen,
rullzer and
skjnldsv
MorrisJobke
force-pushed
the
feature/noid/improve-update-channel-layout
branch
2 times, most recently
from
c49623f to
8d5cda6
Compare
Member
|
MorrisJobke
commented
Feb 12, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsv
previously requested changes
Feb 13, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsv
reviewed
Feb 13, 2019
MorrisJobke
force-pushed
the
feature/noid/improve-update-channel-layout
branch
from
ba198e1 to
36a18b9
Compare
MorrisJobke
force-pushed
the
feature/noid/improve-update-channel-layout
branch
2 times, most recently
from
d4b868a to
aa2135d
Compare
* now the entries are in a popup menu * if a non-default channel is used the entry will be at the bottom * channel descriptions are embeded into the menu * use nextcloud-vue componenets for the channel selector * update nextcloud-vue dependency from 0.6.1 to 0.6.3 * fixes #13806 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
feature/noid/improve-update-channel-layout
branch
from
aa2135d to
15ae633
Compare
Member
Author
|
I fixed the comments by @skjnldsv and this is now fully rebased and squashed. I also adjusted the text for production to be this:
Does this make sense? It should reflect the planned changes from #8799 that is then done to the updater_server. |
jancborchardt
approved these changes
Feb 13, 2019
skjnldsv
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how it looks (normal menu, after and update, with a non-default entry).