don't close input stream when writing in encrypted file

[rummatee]

This addresses issue #13276. Since Sabre checks if the end of the stream has been reached, when the created file is empty, closing the stream creates an error in that case.

				$result = $count > 0;
				if ($result === false) {
					$result = feof($data);
				}

I also don't see, why it would make sense to close that stream that writeStream gets as an parameter, but please tell me if I am missing something.
Please review @nextcloud/encryption

[MorrisJobke]

cc @icewind1991

[MorrisJobke]

Code makes sense 👍

[MorrisJobke]

/backport to stable15

[backportbot-nextcloud]

backport to stable15 in #13588

[tobiasKaminsky]

I do get this:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception</s:exception>
  <s:message>Error while copying file to target location (copied bytes: 0, expected filesize: 0 )</s:message>
</d:error>

on my Android test 0kb upload, always targeting latest master.
It was working some days ago, so this might be the cause here?

[MorrisJobke]

But this was merged over a month ago. There was one change by @rullzer with 0 Byte files in object storages

[tobiasKaminsky]

Ah, I mixed 14.01. with 14.02.

[rullzer]

Also in general. commenting on month old merged PRs is a good way to have your additional questions ignored ;)

[yingriyanlong]

Hi, I'm using nextcloud server 15.04 and got the same information as @tobiasKaminsky when I upload a 0kb file using Windows Client 2.51final.

[MorrisJobke]

Hi, I'm using nextcloud server 15.04 and got the same information as @tobiasKaminsky when I upload a 0kb file using Windows Client 2.51final.

Fixed in #14273 most likely.

[KurtCa]

This is not fixed in nextcloud 16.0.1

[MorrisJobke]

This is not fixed in nextcloud 16.0.1

Could you open a new ticket for this then? Thanks