Don't require 2FA for requests with Bearer tokens#12538
Closed
jo23sh wants to merge 1 commit intonextcloud:masterfrom
jo23sh:master
Closed
Don't require 2FA for requests with Bearer tokens#12538jo23sh wants to merge 1 commit intonextcloud:masterfrom jo23sh:master
jo23sh wants to merge 1 commit intonextcloud:masterfrom
jo23sh:master
Conversation
Using the same check as in the [SecurityMiddleware](https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php#L171). This fixes #12498 for me Signed-off-by: Josua Hunziker <stjosh@users.noreply.github.com>
Member
|
This is not correct. This would basically disable 2FA for all bearer totkens. The token itself is already an apptoken so there is no need for this. |
Author
Member
|
@StJosh I'm looking into it. It should just see this is a proper apptoken. I'll report back when I know more. |
Member
|
Let use #12543 |
Author
|
Fair enough - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the same check as in the SecurityMiddleware. This fixes #12498 for me