Sidebar fixes, mostly fixing design of tabs

[jancborchardt]

The tabs in the Files sidebar were utterly broken, which is very obvious on any screen which is not 4k resolution, or as soon as the 4th tab shows. This is especially visible now because we added nice icons to all the tabs.

🤢

So here you go with nicer tab layout:

• Flexbox, using the available width
• Icon above text for better look and more space for tabs
• Adjusted whitespace around

Even if we add Chat it works – cc @danxuliu

---

And even if we really loose our minds 🤯

---

Please review @nextcloud/designers, also cc @nickvergessen & @georgehrke for evaluation with Talk and Calendar apps.

Now this is only a stop-gap solution of course. We still need to work towards limiting the amount of tabs in there as per Sidebar standardization #10289 and Sidebar: combine file Activity, Comments and Versions into unified »Activity« timeline tab #658

[skjnldsv]

Can I suggest to prevent the shrinking of the selected tab? :)

[blizzz]

works well for me

[blizzz]

CI is not happy though

[danxuliu]

Even if we add Chat it works

❤️

@jancborchardt For consistency, could you change this (mainly icons above text) in Talk too? Thanks! :-) (and there is no hurry, it can wait a few days ;-) )

CI is not happy though

One timeout, one unrelated failure due to a known race condition, and a failure that looks like a hiccup... but I will restart the build to be sure ;-)

[MorrisJobke]

Even looks good in (longer) German translation:

[jancborchardt]

Can I suggest to prevent the shrinking of the selected tab? :)

This will look wonky and not stable. The tab widths change then and you can’t use muscle memory. :)

[skjnldsv]

Can I suggest to prevent the shrinking of the selected tab? :)

I guess not 🤣

EDIT: AH! you answered at the same time :p