Fix "checkWellKnownUrl" not being run#11411
Conversation
Hum, I'm not sure you should have run this since you did not change anything related to the settings app :/ |
|
Let me merge the changes into one as admin.js is the only thing that should have changed here. |
The check is run only if its last parameter is true; data() tries to convert the HTML attribute string to an actual JavaScript value, so "true" is returned as an actual boolean instead of an string; as a strict comparison against "true" was used the result was false and thus the checks were not run. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
90b044e to
fe30653
Compare
Oops, my bad; I thought that the files in settings/js/ needed to be built too. Lesson learnt :-) (fast-forward to some time in the future, @danxuliu builds again the Vue app when not needed and asks for advice to the experts; the facepalm was so strong that went backwards in time and I heard it today. True story!).
👍 Thanks! |
The check is run only if its last parameter is
true;data()tries to convert the HTML attribute string to an actual JavaScript value, so"true"is returned as an actual boolean instead of an string; as a strict comparison against"true"was used the result wasfalseand thus the checks were not run.Vue experts, I just run
makeon the settings directory to update the settings-vue.js and settings-vue.js.map files, but they seem to have quite a lot more changed lines than I would expected for a two contiguous line change in the source. I do not know if I did something wrong :-)How to test:
Expected result:
Error messages saying Your web server is not properly set up to resolve... for CardDAV and CalDAV. If the lines are restored in the .htaccess obviously the errors go away.
Actual result:
No Your web server is not properly set up to resolve... error messages are shown.