Popovermenu fix and token settings design fixes #10546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
enhancement
design
skjnldsv
requested review from
jancborchardt,
juliusknorr,
nickvergessen and
rullzer
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
popover-tokens
branch
from
5884712 to
4ba4038
Compare
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Popover on apps/sessions list looks the same on master and this branch – correct?
Member
|
@skjnldsv see @ChristophWurst comment ;) |
Member
Author
|
@ChristophWurst no, we respect the 44px sizes and the ui looks a bit nicer |
Member
Author
|
rullzer
approved these changes
Aug 9, 2018
Member
Didn't notice any difference while testing but here it's obvious 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tokens devices list to popover standards, fix popover positionning with border (dark theme)
and alignment