Skip to content

Fix app management not providing updates for apps which got disabled #10508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 3 commits into from
Aug 2, 2018
Merged

Fix app management not providing updates for apps which got disabled #10508

rullzer merged 3 commits into from
Aug 2, 2018

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 2, 2018

No description provided.

@nickvergessen
Keep the data of the local app (especially the version)
2dcae4e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Also allow to update apps which are currently not enabled
a9f8ee4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
There is no update available if the app didnt have a version (aka was…
483ad01 
… not installed)

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Aug 2, 2018
rullzer
rullzer reviewed Aug 2, 2018
View reviewed changes
lib/private/Installer.php
$currentVersion = OC_App::getAppVersion($appId);
$newestVersion = $app['releases'][0]['version'];
if (version_compare($newestVersion, $currentVersion, '>')) {
if ($currentVersion !== '0' && version_compare($newestVersion, $currentVersion, '>')) {
Copy link
Member

@rullzer rullzer Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when will it be '0'?

Copy link
Member

@rullzer rullzer Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I should read the commit messages

Copy link
Member Author

@nickvergessen nickvergessen Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server/lib/private/App/AppManager.php

Lines 394 to 397 in f30c14a

if(!$useCache || !isset($this->appVersions[$appId])) {
$appInfo = \OC::$server->getAppManager()->getAppInfo($appId);
$this->appVersions[$appId] = ($appInfo !== null && isset($appInfo['version'])) ? $appInfo['version'] : '0';
}

When the app is not "available". so basically when it's only in the response of the appstore but can not be found locally

rullzer
rullzer approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense!

@rullzer rullzer mentioned this pull request Aug 2, 2018
Closed
58 tasks
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 2, 2018
@rullzer rullzer merged commit 8d08cfc into master Aug 2, 2018
@rullzer rullzer deleted the bugfix/noid/app-management branch August 2, 2018 17:32
@juliusknorr juliusknorr mentioned this pull request Aug 7, 2018
Closed
@MorrisJobke MorrisJobke mentioned this pull request Aug 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @rullzer @juliusknorr