Only show checkbox on hover/focus + accessibility fixes #10482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
enhancement
design
skjnldsv
requested review from
ChristophWurst,
MariusBluem,
danxuliu,
jancborchardt,
juliusknorr and
rullzer
rullzer
approved these changes
Aug 1, 2018
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Fine by me. But @nextcloud/designers should have a look as well
Member
|
I think we should always show them on mobile, otherwise there would be no hint, that you could select multiple entries. |
Member
Author
|
@juliushaertl every app do that on mobile. I never seen any checkbox chown. you can always see that on long click (whatsapp, messenger, gallery...) or clicking the avatar (same here) :) |
Member
|
Ok, didn't thought about that, but makes sense then 😉 |
juliusknorr
approved these changes
Aug 2, 2018
Member
Author
|
Wait a sec, I want to add a class toggle to show all checkboxes! |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Member
Author
|
here, done! :) |
skjnldsv
added
4. to release
Member
Member
Author
|
@rullzer I'm not sure it's related: |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nextcloud/accessibility @nextcloud/designers