Fix inline avatar display for mentions in comments#10288
Merged
MorrisJobke merged 1 commit intomasterfrom Jul 19, 2018
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
jancborchardt
approved these changes
Jul 18, 2018
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Absolutely, suuuper awesome @juliushaertl! :)
Hope @pixelipo likes this too? ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the avatar display in files comments to show them nicely inline, similar to the way riot is displaying them inside chat conversations. See #9273
I think it is way nicer to have those properly inline and even if they are quite small at 16px they still help to recognize the mentioned person instead of going with just the name. And it is way nicer than before. 🙈
Before
After
When writing:
Inside some text:
@nextcloud/designers