IPv6 in mysql address

[genofire]

there could be more then one : in it, so explode is no solution for it.

php > print_r (explode(":","[::1]:3306",2));
Array
(
    [0] => [
    [1] => :1]:3306
)

server/lib/private/DB/ConnectionFactory.php

Line 198 in 01482b3

list($host, $portOrSocket) = explode(':', $host, 2);

[genofire]

Maybe list($portOrSocket, $host) = array_map('strrev',explode(":",strrev($host),2)); is a solution:

php > print_r (array_map('strrev',explode(":",strrev("[::1]:3306"),2)));
Array
(
    [0] => 3306
    [1] => [::1]
)
php > print_r (array_map('strrev',explode(":",strrev("unix:/socket"),2)));
Array
(
    [0] => /socket
    [1] => unix
)

[tflidd]

@nickvergessen

[cwiedmann]

`php > print_r (array_map('strrev',explode(":",strrev("unix:/socket"),2)));

Out of curiosity:
You define the socket with "unix:/". In the [manual] (https://docs.nextcloud.com/server/13/admin_manual/configuration_server/config_sample_php_parameters.html) I can read:

to specify a Unix socket use localhost:/path/to/socket

Of course, in the section about [database configuration] (https://docs.nextcloud.com/server/13/admin_manual/configuration_database/linux_database_configuration.html#postgresql-database) only a leading slash is used:

"dbhost" => "/var/run/postgresql",

IMHO, you should first test if it is a path or a host. But, what is allowed for a path, or how must/should it looks like?

[genofire]

@cwiedmann this was the test if it is still possible with my idea of a fix. (and it work also with a path)

php > print_r (array_map('strrev',explode(":",strrev("/var/run/postgresq"),2)));
Array
(
    [0] => /var/run/postgresq
)

---

Nothing matter it is not possible to use a IPv6-Address for a dbhost like [::1]:3306 i got a error :1]:3306 is no valid port - because my mention lines did not split host and port on a correct way.
That what this issue is about.

[cwiedmann]

@genofire
Your code is also not working if you omit the port.

Well, splitting the port from a hostname/ip is easy if you know it's not a path. So there is just the path case. And the manual shows two different example (have to use "localhost:/path" vs. "/path").

[cwiedmann]

just an example how you can solve the problem:

$host = $this->config->getValue('dbhost', '');
if (false !== strpos($host, '/')) {
	$connectionParams['unix_socket'] = $host;
} else {
	$host = parse_url('tcp://' . $host);
	$connectionParams['port'] = (isset($host['port'])) ? $host['port'] : null;
	$connectionParams['host'] = $host['host'];
}

(assuming only a path does have a slash)

[nickvergessen]

Can you test this change:
lib/private/DB/ConntectionFactory.php
find:

			if (strpos($host, ':')) {
				// Host variable may carry a port or socket.
				list($host, $portOrSocket) = explode(':', $host, 2);
				if (ctype_digit($portOrSocket)) {
					$connectionParams['port'] = $portOrSocket;
				} else {
					$connectionParams['unix_socket'] = $portOrSocket;
				}
			}

replace with:

			$matches = [];
			if (preg_match('/^(.*):([^\]:]+)$/', $host, $matches)) {
				// Host variable carries a port or socket.
				$host = $matches[1];
				if (is_numeric($matches[2])) {
					$connectionParams['port'] = (int) $matches[2];
				} else {
					$connectionParams['unix_socket'] = $matches[2];
				}
			}