Fix spacing for thumbnails and recommendations list#156
Merged
ChristophWurst merged 1 commit intomasterfrom Dec 10, 2019
Merged
Fix spacing for thumbnails and recommendations list#156ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
jancborchardt
requested review from
ChristophWurst,
gary-kim,
juliusknorr,
marcoambrosini and
skjnldsv
skjnldsv
approved these changes
Dec 10, 2019
ChristophWurst
requested changes
Dec 10, 2019
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks better, thanks!
Please build the artifacts and commit them :)
Member
|
/compile amend / |
1 similar comment
Member
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
design/fix-spacing
branch
from
3a66352 to
34303d3
Compare
Member
|
Huh, @jancborchardt mind if I rebase? |
Member
do it :) |
gary-kim
force-pushed
the
design/fix-spacing
branch
from
34303d3 to
f415a67
Compare
Member
|
Member
Author
Not at all, thanks! :) @ChristophWurst I added a note about committing the build artifacts: #157 |
Member
|
@jancborchardt rebase |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
design/fix-spacing
branch
from
f415a67 to
832a2f9
Compare
Member
Author
Done! Hope it’s all good now? :D |
gary-kim
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Please review @ChristophWurst @nextcloud/designers