Testing against MariaDB 11.8 for https://github.com/nextcloud/server/…#1295
Open
nickvergessen wants to merge 4 commits intomainfrom
Open
Testing against MariaDB 11.8 for https://github.com/nextcloud/server/…#1295nickvergessen wants to merge 4 commits intomainfrom
nickvergessen wants to merge 4 commits intomainfrom
Conversation
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
8 tasks
5 tasks
|
As mentioned here #1252 (comment), the reason of the incompatibility with 11.8 is that |
Member
|
Mmh, does that mean we need to rename the column, or can this be worked around by quoting the column? |
|
Honestly, I don’t know how quoting the column could be done in the db framework. I haven’t looked into that, and I didn’t spend a lot of time understanding the code. If it’s possible, that could be a workaround, but I don’t know if it’s a good solution in the sense of maintainability.But I see that changing the name is not something done easily either.On 27 Jul 2025, at 09:04, Marcel Klehr ***@***.***> wrote:marcelklehr left a comment (nextcloud/recognize#1295)
Mmh, does that mean we need to rename the column, or can this be worked around by quoting the column?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Member
Author
|
I guess rename (prefix) is easier and less problematic, because the missing quoting would be required in the migration schema logic of Doctrine DBAL etc.
|
marcelklehr
added a commit
that referenced
this pull request
Jul 27, 2025
'vector' is a reserved keyword now in mariadb see #1295 Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
added a commit
that referenced
this pull request
Jul 27, 2025
'vector' is a reserved keyword now in mariadb see #1295 Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
added a commit
that referenced
this pull request
Jul 27, 2025
'vector' is a reserved keyword now in mariadb see #1295 Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
added a commit
that referenced
this pull request
Jul 27, 2025
'vector' is a reserved keyword now in mariadb see #1295 Signed-off-by: Marcel Klehr <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
'vector' is a reserved keyword now in mariadb see #1295 Signed-off-by: Marcel Klehr <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
'vector' is a reserved keyword now in mariadb see #1295 Signed-off-by: Marcel Klehr <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…issues/51596