Conversation
CarlSchwan
approved these changes
Apr 4, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
There is a few style warnings in the diff but other than that it looks good. Thanks 👍
icewind1991
force-pushed
the
profile-db-backtrace
branch
2 times, most recently
from
adca8e0 to
6992968
Compare
Member
|
While trying this locally I found two minor issues in the backtrace component:
Both cases should be handled now :) |
icewind1991
force-pushed
the
profile-db-backtrace
branch
from
2f82d71 to
d250db9
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
profile-db-backtrace
branch
from
d250db9 to
1cabf22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easier to figure out where a query comes from
See also nextcloud/server#31833