Closed
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Member
Member
|
I think we can do this but we should also check for password_policy/lib/Validator/HIBPValidator.php Lines 63 to 76 in 37b2f4e |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Member
|
Actually I moved this a directly into the config check, this also makes it more obvious for admins in the UI that somehow HIBP is not enabled :) |
MorrisJobke
approved these changes
May 25, 2021
MorrisJobke
reviewed
May 25, 2021
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
|
Okay - this is somehow merged into master but not marked in this PR: f356c91 |
98 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl