Merged
Conversation
4 tasks
provokateurin
requested changes
Feb 21, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just one thing to fix.
src/ResponseType.php
Outdated
Comment on lines
134
to
135
| null, | ||
| $binaryType, |
Member
There was a problem hiding this comment.
Suggested change
| null, | |
| $binaryType, | |
| null, | |
| null, |
Since there is no default content type there can't be a default type either.
Member
|
Ah and could you update nextcloud/server#49995 with the OpenAPI changes generated by this PR? Just to verify that they are good before releasing this. |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/noid/add-response-type
branch
from
60740bb to
a0c9b27
Compare
Contributor
Author
Done |
provokateurin
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional response type added by PR nextcloud/server#49995