Fix box shadow on notifications drop down#106
Merged
jancborchardt merged 1 commit intomasterfrom Dec 20, 2017
Merged
Conversation
Merged
Member
Author
|
Together with nextcloud/server#7572 this also fixes the same problems in IE11 ;) |
pixelipo
reviewed
Dec 20, 2017
| @@ -9,8 +9,6 @@ | |||
| min-height: 100px; | |||
There was a problem hiding this comment.
I think this and the next line are not necessary any more (min- and max-height). Tested only on Firefox and Chrome.
Member
Author
There was a problem hiding this comment.
The min-height is still needed, but max-height can be dropped. Adjusted it in this PR.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix-safari
branch
from
6653e81 to
94056f3
Compare
pixelipo
approved these changes
Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nextcloud/designers
Before the overflow has also hidden the shadow. With this the overflow is on a child element and not causing the shadow to hide anymore (same as before #89 ).