chore(tests): Cleanup bootstrap.php to be forward-compatible#1418
Merged
chore(tests): Cleanup bootstrap.php to be forward-compatible#1418
Conversation
4 tasks
provokateurin
approved these changes
May 22, 2025
Member
|
CI seems to be stuck |
Contributor
I think there is no such workflow anymore but still setup as required |
tacruc
approved these changes
May 23, 2025
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/cleanup-tests-bootstrap
branch
from
77cb264 to
758b577
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new tests/autoload.php from nextcloud/server instead of messing directly with OC private autoloader.
See nextcloud/server#52951 and nextcloud/server#52945 for context.
I did not add a direct reference to
tests/autoload.phpfor this app becausetests/bootstrap.phpis required which requires it indirectly.