external storage: photo-scan bug

[szaimen]

Describe the bug
when using external storage: you have to run the initial maps:scan-photos for every user

To Reproduce
Steps to reproduce the behavior:

1. create an external storage folder with photos with gps-tag in it for more than one user
2. scan the photos for one specific user with occ maps:scan-photos userid
3. the photos appear only for that specific user in the maps app

Expected behavior
the scanned photos should appear for all users with access to the external storage folder

Desktop (please complete the following information):
Nextcloud 17.0.2
maps app 0.1.4

Additional context
The problem with that is, if you have a large external storage folder, with many photos, you had to scan this folder for every user again, which is not that efficient.
So a better way would be connecting the information to the external storage id -> so if you have access to that external storage folder, you will automatically see the photos on the map, if they were scanned before - no matter with which userid you have scanned that folder.

BTW: I guess the same problem would appear while using the groupfolders-app

[Skip75]

I think it's related to that enhancement ##123

[andyg2]

I've just got to the bottom of an exploding background jobs table and tracked it back to Maps.
Our office of some 40 people each have access to a shared folder of some half million images. For the past 2 days NC has been sluggish and I find 50 million background jobs. for OCA\Maps\BackgroundJob\AddPhotoJob. I have never asked to scan for photos and neither have the staff who usually only access via webdav or a desktop agent. Is this an automatic feature because it should come with a warning if it is.
I only wanted to share some job site locations and have no interest in geotagging photos or tracks.
How do I clean my database because the uninstall did not tidy up after itself?
Thanks..

[tacruc]

I guess deleting those lines in the table should work. @nickvergessen?

[andyg2]

I guess deleting those lines in the table should work. @nickvergessen?

Many thanks, I've done that now, you've saved me a long evening looking for remnants.
I was thinking that maybe a notification could occur if the scan job would add an excessive number of photos.

[nickvergessen]

Seems like the background job is added wrongly. Will have a look later today

[szaimen]

Many thanks, I've done that now, you've saved me a long evening looking for remnants.
I was thinking that maybe a notification could occur if the scan job would add an excessive number of photos.

@andyg2 which database rows did you delete? Maybe I have to do that as well...

[nickvergessen]

Okay, so multiple things to reply to:

1. From my POV it is a valid request to not scan images/photos for geo location
2. It would make a lot sense to bind the findings to the storage, this also means if a user is added later, they immediately have all the locations available. But it gets pretty complicated to make this fully work (with shares e.g. because the files belong to a different storage for the target user and the owner)
3. Deleting the background jobs (if you don't want photos to be linked) can be done with the following query: DELETE FROM oc_jobsWHEREclass LIKE '%Maps%';
4. If you have 50m entries in your jobs table, it very much sounds like you are missing proper set up system cron. Ajax cron is not suitable for "bigger" instances with more then a handful of users or couple of files. I would recommend following the steps in https://docs.nextcloud.com/server/18/admin_manual/configuration_server/background_jobs_configuration.html#cron and your problem should be solved after a day latest.
5. When uploading an image, there seem to be 2 cron jobs added, is that intentional?
   

[Derkades]

Using NC19, maps 0.1.6. Even after running occ maps:scan-photos MyUser and it reporting that it added 16 thousand photos, I still don't see anything in the maps app

EDIT: I now read somewhere that it does not add photos, but adds background jobs to scan photos. The cronjobs are taking longer to complete now so I guess it's doing something

EDIT 2: Yes, after waiting for 20 minutes they show up now.