Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
changed the title
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Wild guess: did you somehow break the click handler binding and the app tries to navigate to |
Easy, I can do that. Doesn't have to be in this PR as that's independent. |
Why do we need js for this? |
js/templates/account.html
Outdated
| {{#if hasFolders}} | ||
| <li class="account-toggle-collapse">{{toggleCollapseMessage}}</li> | ||
| <li class="account-toggle-collapse"> | ||
| <a href="">{{toggleCollapseMessage}}</a> |
There was a problem hiding this comment.
here you go. The newly added a element causes an unexpected navigation. The click handler should call event.preventDefault().
There was a problem hiding this comment.
preventDefault isn't working here, wefound something else. ;)
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
Pushed a fix for the other two issues, the position was indeed CSS only. :) |
|
❤️ |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions. |
3 participants
This is pretty much done now! Needs some testing with subfolders @nextcloud/mail
TODO where I need JS help: