show error-view instead of yellow notification on content loading errors#57
show error-view instead of yellow notification on content loading errors#57jancborchardt merged 1 commit intomasterfrom
Conversation
|
Maybe we can also find a better and shorter wording for "Error while loading the selected message" 😉 |
|
"Unable to load the desired message" ? :) |
|
For the individual folders, I would use the folder-relevant icon for the error icon. For individual mails or when there is no specific icon I’d say let’s use the mail-envelope-icon. The messages could be a bit improved to this to be less sterile and also a bit fun and helpful. First line is h2 in emptycontent, and second line is the
Yes, with the :( smiley. Maybe even cycle randomly between :( and :\ and :/ and ;( – that makes the error message at least a bit fun. ;) |
|
@jancborchardt something like this? We'll need a generic icon for non-special-use folders. Could could make one, please? |
Ah, didn't read that before… |
|
oh, we have an 'icon-folder' too. Hmm… |
|
But give the smileys noses, please! 😃 Von: Jan-Christoph Borchardtmailto:notifications@github.com For the individual folders, I would use the folder-relevant icon for the error icon. For individual mails or when there is no specific icon I’d say let’s use the mail-envelope-icon. The messages could be a bit improved to this to be less sterile and also a bit fun and helpful. First line is h2 in emptycontent, and second line is the We couldn’t load the Inbox :( (the Sent mails, the Trash etc.) Vacation planning isn’t loading : There was a problem loading the message :( Yes, with the :( smiley. Maybe even cycle randomly between :( and :\ and :/ and ;( – that makes the error message at least a bit fun. ;) — |
|
@ChristophWurst, yeah, basically like that! :) Is it not possible to bold the foldername instead of using quotes? That would look waaay better. Also let’s please use the mail icon instead of the folder icon. We do not use the folder icon anywhere in the mail app – it belongs to Files. In fact other mail apps like Gmail use the concept of »Tags« rather than folders so let’s use a generic one. And below that sentence, put a |
tried that with search already but failed. Maybe someone can enhance that later |
ChristophWurst
force-pushed
the
error-view
branch
from
59f9ee3 to
52fd506
Compare
| }) | ||
| ]; | ||
| var texts = _.map(rawTexts, function(text) { | ||
| return text.replace('{tag}', '<strong>').replace('{endtag}', '</strong>'); |
There was a problem hiding this comment.
Are you trying to bold the folder name here?
There was a problem hiding this comment.
see #57 (comment) :)
If the strong is correctly outputted on the html and still isn't displayed bold, this could be because the strong css value "font-weight" has been reset. If so just use a span and set it in css. Should be enough! ;)
There was a problem hiding this comment.
Riight, we need to add in our CSS:
strong { font-weight: 600; }
@skjnldsv great to see you back here by the way! :)
ChristophWurst
force-pushed
the
error-view
branch
from
52fd506 to
3ed009d
Compare
| }); | ||
| }); | ||
|
|
||
| folder.set('active', true); |
There was a problem hiding this comment.
small bugfix: if the first folder fails loading, folder was undefined here and therefore an error was shown in the js console.
|
NICE, looks very good ;D 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions. |
4 participants
implements part 1 of #56 – the error view.
Examples:
@te-online @skjnldsv @jancborchardt how about a nice error-logo above the error message to be consistent with the no messages in this folder and no search results view?