[stable25] Adjust server version to test against#886
Merged
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Antreesy
approved these changes
Jun 7, 2023
Collaborator
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Seems legal, but don't we need to test against other PHP versions as well in these places, like for sqlite: php-versions: ['7.4', '8.0', '8.1'] ?
Contributor
Author
I think this is done because sqlite is quite cheap (performance) so all supported PHP versions are tested and for the other database systems only the recommended version is tested. At least that is how most apps are tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set server version to
stable25instead of master for phpunit tests of thestable25branch.