Conversation
…p with react-transition-group Just tried to follow the migration guide: https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md This commit addresses the issue that the invisibl log-entries experienced with Nextcloud v24 are caused by pulling in conflicting version of react-dom. See issue #699. Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
artonge
approved these changes
Nov 28, 2022
Member
|
/compile amend / |
nextcloud-command
force-pushed
the
fixes-24
branch
from
9a0f5b5 to
5c3f28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports most of #821 but not the newline bits