Skip to content

fix: Allow older app values to be set#1075

Merged
susnux merged 1 commit intomasterfrom
fix/relativedates-setting
Dec 14, 2023
Merged

fix: Allow older app values to be set#1075
susnux merged 1 commit intomasterfrom
fix/relativedates-setting

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Dec 13, 2023

Resolves #1073

Previously the app value relativedates were already used but set to an empty string in case of false. This needs to be handled correctly for users updating from 27 to 28.

@susnux
fix: Allow older app values to be set
6faf997 
Previously the app value `relativedates` were already used but set to an empty string in case of `false`.
This needs to be handled correctly for users updating from 27 to 28.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from artonge and szaimen December 13, 2023 01:06
@susnux
Copy link
Contributor Author

susnux commented Dec 13, 2023

/backport to stable28

This was referenced Dec 13, 2023
Closed
Closed
@susnux susnux merged commit bedcea1 into master Dec 14, 2023
@susnux susnux deleted the fix/relativedates-setting branch December 14, 2023 14:42
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 14, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

No one assigned

Labels

3. to review bug feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: NC28 syntax error accessing /settings/admin/logging

2 participants

@susnux @artonge