This repository was archived by the owner on Nov 1, 2020. It is now read-only.
[stable17] Append the autocomplete results to the dropdown container#571
Merged
[stable17] Append the autocomplete results to the dropdown container#571
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
approved these changes
Mar 4, 2020
GretaD
approved these changes
Mar 4, 2020
Member
Author
|
Failures unrelated ... tests are broken since ages https://travis-ci.org/nextcloud/gallery/builds/658035572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
When trying to share withing the gallery app the autocomplete suggestions were hidden, as they were added to the body and therefore overlayed by the main slideshow which was a z-index of 10000. Appending it to the dropdown makes it use the existing styles for overlaying in
gallery/css/slideshow.css
Lines 190 to 193 in 8776be9