This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Conversation
In the "Files" app the actions that require the create permission (those marked as "creatable") are hidden in folders that do not have that permission. However, as there is only one ".actions" element inside "#controls" and that ".actions" element also has the "creatable" CSS class appending the gallery button to it meant that the gallery button was hidden in folders without create permissions. Now the gallery button is appended to the "#controls" element instead, and thus it is no longer affected by the permissions of the folder. As the button is now appended to the "#controls" element its top margin was increased to align it with the rest of the buttons (as the ".actions" element uses a padding of 5px), and as the button appears in the top right corner of the contents its right margin was set to the same value as the top margin to "frame" the button. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
backport-request
This was referenced Feb 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
=========================================
Coverage 82.55% 82.55%
Complexity 360 360
=========================================
Files 38 38
Lines 1313 1313
=========================================
Hits 1084 1084
Misses 229 229Continue to review full report at Codecov.
|
danxuliu
deleted the
fix-gallery-button-hidden-in-folders-without-create-permission
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that the button to switch to the Gallery app is shown in read-only folders.
This is necessary for the fix introduced in nextcloud/server#8589, and it requires nextcloud/server#8588.