Conversation
This comment has been minimized.
This comment has been minimized.
6df316f to
d9e5d31
Compare
e5f20c4 to
ed3869e
Compare
|
Just found a nice trick on Deck, to have separate implementation depending on NC-Version. Now we have the Settings without section for NC<20 and with section for NC>=20 😍 |
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
|
@skjnldsv From my side this is good to go, why developing? |
65bc2a4 to
3724192
Compare
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Because I thought this was not done :p |
nickvergessen
left a comment
There was a problem hiding this comment.
Looks good, didn't test.
But note you can only use the new type after a release and as far as I know apps can't require patch versions on nextclouds. I therefor would only use it from 21 onwards
Yeah, i now put the existing type 'highlighted' into the parser. So when to move to the new type will now depend on how far we can backport nextcloud/server#25758 and when we set the corresponding (major-)minversion. I have a ticket open for this. |
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
To remove and replace as soon as NC19 is out of support on Forms. Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
3724192 to
478fcc8
Compare
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com> Signed-off-by: tsdicloud <bernd.rederlechner@t-systems.com>
Now creating some Activity:
For Submissions, Activities will be merged. Settings are separated into Share & Submission, so Notifications & Emails can be set up separately.
@jancborchardt As usual - i think you have some better wording for the texts? 😉
ActivitySettings.Fixes #12 for now.