fix: enable deno_core feature for JavaScript expression evaluation#134
Merged
oleksandr-nc merged 1 commit intonextcloud:mainfrom Feb 9, 2026
Merged
Conversation
Since version 1.3.0, users get the error: "ExecutionErr: Error during isolated evaluation of expression: Deno core is not enabled" This happens because the `deno_core` Cargo feature was not enabled when building Windmill. This feature is required for Windmill to evaluate JavaScript/TypeScript expressions in workflows (e.g., `flow_input.event.values[0].value[0].id`). The `deno_core` feature enables the embedded JavaScript runtime based on deno_core and V8. This is different from the external Deno binary (`/usr/bin/deno`) which is already included in the image. Fixes nextcloud#129 Signed-off-by: Strobel Pierre <strobelpierre@gmail.com>
strobelpierre
force-pushed
the
fix/enable-deno-core-feature
branch
from
4916568 to
19f260a
Compare
|
I'm testing this particular fix, and it appears to work for the core issue. |
|
It might also need other features enabled in there, |
oleksandr-nc
approved these changes
Feb 9, 2026
Contributor
oleksandr-nc
left a comment
oleksandr-nc
left a comment
There was a problem hiding this comment.
Thank you for looking into this issue and offering a solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deno_coreCargo feature when building Windmill to fix JavaScript expression evaluation in workflowsProblem
Since version 1.3.0, users get the error:
This happens because the
deno_coreCargo feature was not enabled when building Windmill. This feature is required for Windmill to evaluate JavaScript/TypeScript expressions in workflows (e.g.,flow_input.event.values[0].value[0].id).Solution
Add
deno_coreto the features build argument in the Makefile:--build-arg features=python→--build-arg features=deno_core,pythonThe
deno_corefeature enables the embedded JavaScript runtime based on deno_core and V8. This is different from the external Deno binary (/usr/bin/deno) which is already included in the image.Test plan
make init && make build-amd64Fixes #129