Upgrade @nextcloud/vue from 5.4.0 to 7.5.0#815
Merged
Conversation
- Update markup - Remove dropped props Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
requested review from
JuliaKirschenheuter,
nickvergessen,
skjnldsv and
szaimen
Member
Author
|
/backport to stable25 |
This was referenced Jan 27, 2023
szaimen
reviewed
Jan 27, 2023
Collaborator
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Works in my testing. However the left arrow is not usable with keyboard-enter. (it brings you not to the former slide back and instead displays the same slide again).
Click do expand
Member
Author
|
szaimen
approved these changes
Jan 27, 2023
Collaborator
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM then for now if it gets fixed in a follow-up
1 task
Member
Author
Let's do a bump after the fix is released then
Tracking in #831 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade https://github.com/nextcloud/nextcloud-vue + adapt markup
Fix "Maximum call stack size exceeded" error from focus-trap when opening from menu entry
Related