Conversation
jancborchardt
previously requested changes
Sep 6, 2022
Member
There was a problem hiding this comment.
The mobile version looks good, but the icon in the "next" button seems too far to the left?
And for the desktop version, introducing a big dedicated space for the button looks a bit off. The overlap is fine, we just need to have nicer placing.
On tech-preview it looks like this, floating in the bottom right of the modal, which is actually great, and it scrolls so all fine. (Only weird thing is the logo is missing)

d11e7aa to
1865f01
Compare
Collaborator
Author
Collaborator
Author
|
/compile amend / |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1865f01 to
2498d2e
Compare
Pytal
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close nextcloud/server#33828 and another issue with the button.
Signed-off-by: szaimen szaimen@e.mail.de