Improve code blocks in markdown rendering#120
Merged
MorrisJobke merged 3 commits intomasterfrom Oct 23, 2018
Merged
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
Author
|
I also added some margin bottom to the details sections: Before: After:
|
juliusknorr
reviewed
Oct 16, 2018
css/public-share.scss
Outdated
| @@ -77,6 +77,9 @@ | |||
| background-color: rgb(242, 242, 242); | |||
| border-radius: 3px; | |||
| padding: 0px 2px 2px 2px; | |||
Member
There was a problem hiding this comment.
Some padding on the left (maybe a bit more in general) would be good I think. Besides that 👍
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
skjnldsv
approved these changes
Oct 23, 2018
Member
Author
|
Backport in #121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: