Conversation
The embedded PDF viewer is shown in an iframe in front of the of the Files app by using absolute positioning. Since Nextcloud 14 the parent element of the iframe uses a flex layout, and the previous sibling of the iframe, the "app-content" element, is shown with "flex-basis: 100vw". In IE 11 the scenario above causes the iframe to be shown to the right of "app-content" instead of in front of it; it is necessary to explicitly set "left: 0" to force the iframe to be aligned to the left of its positioning context (which in this case is its parent element) and thus in front of "app-content". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Sep 26, 2018
This was referenced Sep 27, 2018
skjnldsv
deleted the
stable14-95-fix-embedded-viewer-with-new-server-layout-on-ie-11
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #95