chore: Move comments event handler to use proper event dispatcher#6008
Merged
juliusknorr merged 1 commit intomainfrom Jun 28, 2024
Merged
chore: Move comments event handler to use proper event dispatcher#6008juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
24 tasks
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
93e492f to
e73d3b1
Compare
luka-nextcloud
previously requested changes
Jun 19, 2024
Contributor
luka-nextcloud
left a comment
luka-nextcloud
left a comment
There was a problem hiding this comment.
The failed cypress tests don't seem to be related to the code change.
The failed integration test is related to the code change. Seems like comment event was not triggered.
Contributor
There was a problem hiding this comment.
I think this file should be moved to tests/unit/Listeners/CommentEventHandlerTest.php
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
e73d3b1 to
92ec240
Compare
blizzz
requested changes
Jun 27, 2024
| $this->notificationHelper = $this->createMock(NotificationHelper::class); | ||
| $this->cardMapper = $this->createMock(CardMapper::class); | ||
| $this->changeHelper = $this->createMock(ChangeHelper::class); | ||
| $this->commentEventHandler = new CommentEventHandler( |
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
92ec240 to
1b44b50
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
1b44b50 to
261e6d0
Compare
blizzz
approved these changes
Jun 28, 2024
| */ | ||
|
|
||
| namespace OCA\Deck\Activity; | ||
| namespace OCA\Deck\Listeners; |
Member
There was a problem hiding this comment.
😬 okay i guess you can do it that way
Member
Author
There was a problem hiding this comment.
I also addressed the review comment from Luka with it as the namespace of the actual class was changed, it made sense to adapt the text namespace as well ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to nextcloud/server#45951 this moves away from the not so lazy registration of comment event handlers.
Checklist