fix(done): Mark card as undone when updating card#5491
Conversation
As stated in #534 (comment) updating the done property of a card via the REST API (without calling the /done and /undone endpoints explicitly) does only work "one way". This commit allows setting null as new value thus allowing to mark cards as undone without an additional HTTP request but within a usual update request. Refs: #534 #4137 c3b4ed6 Signed-off-by: Stefan Niedermann <info@niedermann.it> Signed-off-by: Niedermann IT-Dienstleistungen <stefan-niedermann@users.noreply.github.com>
|
Thanks a lot for the fix ❤️ |
|
/backport to stable28 |
Refs: #1556 nextcloud/deck#5491 Signed-off-by: Stefan Niedermann <info@niedermann.it>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
2 participants
Summary
As stated in #534 (comment) updating the done property of a card via the REST API (without calling the /done and /undone endpoints explicitly) does only work "one way".
This commit allows setting null as new value thus allowing to mark cards as undone without an additional HTTP request but within a usual update request.
Refs: #534 #4137 c3b4ed6
CC: @desperateCoder @juliushaertl @TehThanos
Checklist