Skip to content

Comments

scroll board by dragging#5293

Merged
juliusknorr merged 1 commit intonextcloud:mainfrom
shoetten:feature/scroll-by-dragging
Nov 16, 2023
Merged

scroll board by dragging#5293
juliusknorr merged 1 commit intonextcloud:mainfrom
shoetten:feature/scroll-by-dragging

Conversation

@shoetten
Copy link
Contributor

Summary

Motivated by the recent uptake of activity in this repo i decided to finally tackle this issue. The PR adds horizontal scrolling of boards by dragging without adding another dependency.

If you wan't the logic out of the board component, i can refactor. I felt like the change was small enough to keep it in there, but feel free to criticize ;)

TODO

  • Test behavior on mobile. I don't have a tablet lying around, but if you have access to a BrowserStack account or similar i'd be happy to test it that way.
  • Test potential edge cases i have not thought about?!

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@shoetten
Copy link
Contributor Author

Cypress is green, so i'm marking this as ready for review.

@shoetten shoetten marked this pull request as ready for review November 16, 2023 12:13
@shoetten shoetten force-pushed the feature/scroll-by-dragging branch from 9c22a68 to 2ff47e3 Compare November 16, 2023 13:21
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shoetten. Thanks a lot for your contribution, this is very much appreciated.

I just left some small comments inline, otherwise this is a great change, happy to merge once clarified. Having the code within the Board component is totally fine with me.

Signed-off-by: Simon Hötten <s+git@hoetten.org>
@shoetten shoetten force-pushed the feature/scroll-by-dragging branch from 2ff47e3 to d17498b Compare November 16, 2023 19:15
@shoetten shoetten requested a review from juliusknorr November 16, 2023 19:21
@juliusknorr juliusknorr merged commit b637c00 into nextcloud:main Nov 16, 2023
@juliusknorr
Copy link
Member

Thanks for the quick adjustment 🥳

@shoetten
Copy link
Contributor Author

Thanks for the fast review 🎉

@shoetten shoetten deleted the feature/scroll-by-dragging branch November 21, 2023 11:12
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make horizontal scrolling easier

2 participants