Merged
Conversation
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com> fix: conflicts
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com> temp
…board #1955 (comment) Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…hing to cleanup or persist there Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: conflicts
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
changed the title
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Contributor
|
Looks good to me! 👍 |
luka-nextcloud
approved these changes
Apr 8, 2022
| await this.$store.dispatch('transferOwnership', { | ||
| boardId: this.board.id, | ||
| newOwner, | ||
| }) |
Contributor
There was a problem hiding this comment.
transferOwnership action has been called with two params: boardId and newOwner, but the action expects 3 params: boardId, newOwner and owner.
juliusknorr
commented
Apr 11, 2022
src/store/main.js
Outdated
| }, | ||
| async transferOwnership({ commit }, { boardId, owner, newOwner }) { | ||
| await axios.put(generateUrl(`apps/deck/boards/${boardId}/transferOwner`), { | ||
| owner, |
Member
Author
There was a problem hiding this comment.
- Drop owner since it is not used by the backend anyways
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2496