Skip to content

Dashboard panel#2115

Merged
juliusknorr merged 14 commits intomasterfrom
enh/dashboard
Aug 26, 2020
Merged

Dashboard panel#2115
juliusknorr merged 14 commits intomasterfrom
enh/dashboard

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 11, 2020 •
edited
Loading

First attempt to implement a dashboard panel for deck to display assigned cards with a due date soon.

Based on the work by @jakobroehrl in #1934 as it uses similar collections of data that we can reuse then.

image

  • The requirement of being assigned doesn’t work well for instances you use on your own. Can we check if there’s assigned cards at all, and if not, show the non-assigned ones you created for example?
  • No emptycontent view
  • auto update of the deck dashboard?

cc @jancborchardt

@juliusknorr juliusknorr added this to the ⭐ 1.1.0 milestone Jul 11, 2020
@rullzer rullzer mentioned this pull request Jul 24, 2020
Closed
Base automatically changed from enh/cardDashboard to master August 20, 2020 11:26
@jakobroehrl
Copy link
Contributor

jakobroehrl commented Aug 21, 2020

grafik
grafik
@juliushaertl I would remove the functions for findAllWithDue since it is now condensed to findAssignedCards

@jakobroehrl jakobroehrl mentioned this pull request Aug 21, 2020
Closed
@jakobroehrl jakobroehrl linked an issue Aug 21, 2020 that may be closed by this pull request
Useful start screen [$5] #12
Closed
@juliusknorr juliusknorr mentioned this pull request Aug 24, 2020
Closed
jancborchardt
jancborchardt approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what you showed me @juliushaertl – as said only the "More items …" should better be "More assigned cards …" for accessibility. :)

@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 24, 2020

as said only the "More items …" should better be "More assigned cards …" for accessibility. :)

Pushed already :)

juliusknorr and others added 12 commits August 25, 2020 21:17
@juliusknorr
Move duedate to separate component
2490062 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fallback for initial state
b14bba2 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Implement dashboard panel
5271812 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix deck icon on dark theme
31a9162 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix styling and rename to actual dashboard api
aa24410 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@jakobroehrl @juliusknorr
show in dashboard and overview all my assigned cards and on private b…
3880b25 
…oards all due cards

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@jakobroehrl @juliusknorr
hide overdue if empty
0dfa241 
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@juliusknorr
Use @nextcloud/vue-dashboard
d9e69d5 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Remove invalid addScript call
6af9af9 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Apply to new .theme--dark class
7a1acaf 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Some cleanup on the filtering
0b23401 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix styling and scroll behavior
44bf528 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix php cs
c87c37f 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fi stylelint
f781537 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 25, 2020

@jakobroehrl Could you have another look? I'd say we get this in as it is and iterate over the rest in follow-ups.

jakobroehrl
jakobroehrl approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nice!

@juliusknorr juliusknorr merged commit 12024a7 into master Aug 26, 2020
@juliusknorr juliusknorr deleted the enh/dashboard branch August 26, 2020 15:02
@juliusknorr juliusknorr mentioned this pull request Sep 1, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@jakobroehrl jakobroehrl jakobroehrl approved these changes

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

⭐ 1.1.0

Development

Successfully merging this pull request may close these issues.

Useful start screen [$5]

3 participants

@juliusknorr @jakobroehrl @jancborchardt