fix(daemon-name): check for forbidden character in daemon name#741
Merged
oleksandr-nc merged 1 commit intomainfrom Jan 8, 2026
Merged
fix(daemon-name): check for forbidden character in daemon name#741oleksandr-nc merged 1 commit intomainfrom
oleksandr-nc merged 1 commit intomainfrom
Conversation
kyteinsky
approved these changes
Jan 8, 2026
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
fix/restrict-control-chars-in-daemonname
branch
from
da139fb to
753c12b
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable32 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a validation flaw where daemon names containing control characters (newlines, tabs, null bytes) could bypass uniqueness checks and create undeletable entries.
Adds validation in registerDaemonConfig() and updateDaemonConfig() to reject names containing ASCII control characters (0x00-0x1F, 0x7F).